Bump local dependencies#195
Conversation
There was a problem hiding this comment.
Pull request overview
The PR title declares improvements to integration tests of the (when) option compilation, but the diff contains a much broader set of changes: a Gradle wrapper upgrade with a rewritten gradlew.bat, two new .agents skills (bump-version, bump-gradle) and a rewritten version-policy.md, relocation of dependency reports to docs/dependencies/ with a new DependencyReportOutputTest, refactored ErrorPlaceholder imports across WhenOption, WhenGenerator, and LocalDateValidator, and version bumps for Validation, Time, CoreJvmCompiler, and the project itself. No new or updated (when) integration tests are visible.
Changes:
- Updated
ErrorPlaceholderimports (and switchedRuntimeErrorPlaceholder→ErrorPlaceholderinLocalDateValidator). - Bumped Gradle wrapper to 9.5.1, rewrote
gradlew.bat, and updated agents/skills documentation. - Moved dependency reports under
docs/dependencies/with a new buildSrc test.
Reviewed changes
Copilot reviewed 23 out of 25 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| version.gradle.kts | Snapshot version bump 240→241 |
| validation/.../WhenOption.kt | Re-grouped ErrorPlaceholder imports under io.spine.validation |
| validation/.../WhenGenerator.kt | Same import refactoring |
| time/.../LocalDateValidator.kt | Switched runtime placeholder type — needs verification |
| gradlew.bat | Rewritten error-handling flow (suspect missing termination after error paths) |
| gradlew | Updated source-template URL comment |
| gradle/wrapper/gradle-wrapper.properties | Bumped Gradle to 9.5.1; added retries=0/retryBackOffMs |
| CLAUDE.md | Fixed TOC path to .agents/_TOC.md |
| buildSrc/.../DependencyReportOutputTest.kt | New tests for report output location |
| buildSrc/.../PomGenerator.kt | Writes pom under docs/dependencies/; no longer deletes prior file |
| buildSrc/.../Paths.kt | Added outputDirectory and outputFile() helpers |
| buildSrc/.../LicenseReporter.kt | Writes merged report under docs/dependencies/ |
| buildSrc/.../Validation.kt | Version bump 414→421 |
| buildSrc/.../Time.kt | Version bump 238→240 |
| buildSrc/.../CoreJvmCompiler.kt | Version bumps for dogfooding/IT |
| .gitignore | Ignore /.claude/worktrees/ |
| .github/workflows/ensure-reports-updated.yml | Step renamed |
| .agents/version-policy.md | Rewritten to point at bump-version skill |
| .agents/skills/writer/SKILL.md | Added typographic-quote guidance |
| .agents/skills/bump-version/{SKILL.md,agents/openai.yaml} | New skill |
| .agents/skills/bump-gradle/{SKILL.md,agents/openai.yaml} | New skill |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
# Conflicts: # .agents/version-policy.md # CLAUDE.md # config # time/src/main/kotlin/io/spine/time/validation/LocalDateValidator.kt # validation/src/main/kotlin/io/spine/tools/time/validation/java/WhenGenerator.kt # validation/src/main/kotlin/io/spine/tools/time/validation/java/WhenOption.kt # version.gradle.kts
alexander-yevsyukov
changed the title
(when) option compilation| # Input: hook JSON on stdin (Claude Code passes tool_input.file_path). | ||
| # Exit: 0 always (post-tool-use; never block). | ||
| # | ||
| set -eu | ||
|
|
||
| input=$(cat) | ||
| file=$(printf '%s' "$input" | jq -r '.tool_input.file_path // empty') | ||
|
|
||
| [ -z "$file" ] && exit 0 |
| set -eu | ||
|
|
||
| input=$(cat) | ||
| file=$(printf '%s' "$input" | jq -r '.tool_input.file_path // empty') | ||
|
|
||
| case "$file" in | ||
| */version.gradle.kts|version.gradle.kts) |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8f3432f133
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #195 +/- ##
============================================
+ Coverage 83.88% 83.97% +0.09%
- Complexity 304 305 +1
============================================
Files 60 60
Lines 1086 1086
Branches 46 46
============================================
+ Hits 911 912 +1
Misses 165 165
+ Partials 10 9 -1 🚀 New features to boost your workflow:
|
This PR updates dependencies on Base, Compiler, CoreJvm Compiler, and Time.
Other notable changes
configwas applied.